gh-101754: document that on Windows, keys in os.environ are converted to uppercase
#101840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. I think we can move it up to just below the "On Unix" paragraph that talks about encodings. The uppercasing is handled in roughly the same way that the encoding is, so may as well be presented at the same level. |
|
Thanks @zooba, I've moved it to a new paragraph just below the "On Unix" one. Here's how it looks now
Please let me know if there is anything else :) |
|
That's great, thanks! |
zooba
added
OS-windows
needs backport to 3.10
|
GH-102393 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2023
…to uppercase (pythonGH-101840) (cherry picked from commit 4e7c0cb) Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
|
GH-102394 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2023
…to uppercase (pythonGH-101840) (cherry picked from commit 4e7c0cb) Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Mar 4, 2023
* main: pythongh-102021 : Allow multiple input files for interpreter loop generator (python#102022) Add import of `unittest.mock.Mock` in documentation (python#102346) pythongh-102383: [docs] Arguments of `PyObject_CopyData` are `PyObject *` (python#102390) pythongh-101754: Document that Windows converts keys in `os.environ` to uppercase (pythonGH-101840) pythongh-102324: Improve tests of `typing.override` (python#102325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix #101754.
Relevant:
This PR adds the third note:
os.environforcibly upper-cases keys on case-insensitive OSs #101754