-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[3.9] bpo-42853: Fix http.client fails to download >2GiB data over TLS (
- Loading branch information
Showing
2 changed files
with
33 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2021-07-28-15-50-59.bpo-42853.8SYiF_.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fix ``http.client.HTTPSConnection`` fails to download >2GiB data. |
153365d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lib/http/client.py
153365d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@methane can you help us here a bit if possible? This reverts the chance that broke the downloads for > 2GB over http correct? Which sub-version of 3.9 is this on? And this means that 3.9 with OpenSSL versions < 1.1.1 would still work with this revert?
153365d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct.
You can see changelog. https://docs.python.org/3.9/whatsnew/changelog.html#changelog
Put "42853" into "Filter entries by content:" form. You can find which micro version shipped this fix.
I am not OpenSSL expert but I think yes.