-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenks #1634
Jenks #1634
Conversation
I would prefer a PR that makes passing the pre-computed bins so users could use whatever they want. However, that may be too complex and would break a lot of code. With that said, this PR is fine and it makes sense. My only request is to move the import inside the if-clause and add or add try/except clause for it at the top so we cab make it optional. I don't want to increase the number of dependencies in folium. |
Of course. To be clear, you want to put the import inside of the if-clause or add a try/except clause, not both, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Have some comments, could you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also include the notebook output in a commit? That way it will show up here: https://nbviewer.org/github/pmains/folium/blob/jenks/examples/Jenks.ipynb
Thank you @pmains! Nice addition. |
This feature change adds Jenks Natural Breaks Optimization to choropleths created using Folium.
https://en.wikipedia.org/wiki/Jenks_natural_breaks_optimization