Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add control_geocoder plugin #1323

Merged
merged 7 commits into from
May 30, 2020
Merged

Conversation

WBP20
Copy link
Contributor

@WBP20 WBP20 commented May 8, 2020

Add a leaflet plugin to search for cities by geocoding through OSM/Nominatim

folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
folium/plugins/control_geocoder.py Outdated Show resolved Hide resolved
@Conengmo
Copy link
Member

Conengmo commented May 8, 2020

Great. Don't worry about stickler, I'll get those.

folium/plugins/__init__.py Show resolved Hide resolved
folium/plugins/geocoder.py Outdated Show resolved Hide resolved
@Conengmo
Copy link
Member

@WBP20 I made some changes. Can you check if everything still works for you? Note that I renamed the class, you'll find it at folium.plugins.Geocoder.

@Conengmo Conengmo marked this pull request as ready for review May 21, 2020 08:29
@Conengmo Conengmo merged commit c8707b1 into python-visualization:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants