Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-working example of how we could expose chunk boundaries #20

Merged
merged 6 commits into from
Nov 7, 2016

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Nov 1, 2016

See gh-19

@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 100% (diff: 100%)

Merging #20 into master will not change coverage

@@           master   #20   diff @@
===================================
  Files          20    20          
  Lines         869   876     +7   
  Methods         0     0          
  Messages        0     0          
  Branches      169   169          
===================================
+ Hits          869   876     +7   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 3daedec...0f2813f

@Lukasa
Copy link
Member

Lukasa commented Nov 3, 2016

Ok @njsmith, here's the necessary extra patches to get this to look something like sensible. Before I go on to write the other ancillary stuff, do you think this approach seems acceptable? If you do, would you like me to also write some narrative documentation about how to never ever use this for anything, and also to write up a changelog entry?

@njsmith
Copy link
Member Author

njsmith commented Nov 3, 2016

This all looks sensible, yeah. And yes please to both. We don't have
anything else in flight right now so changelog conflicts shouldn't be a big
deal.

On Nov 3, 2016 9:38 AM, "Cory Benfield" notifications@github.com wrote:

Ok @njsmith https://github.com/njsmith, here's the necessary extra
patches to get this to look something like sensible. Before I go on to
write the other ancillary stuff, do you think this approach seems
acceptable? If you do, would you like me to also write some narrative
documentation about how to never ever use this for anything, and also to
write up a changelog entry?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/njsmith/h11/pull/20#issuecomment-258198843, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAlOaC1Q49rIjO67O347iz9ncq4jxA2Wks5q6g33gaJpZM4Kmqsu
.

@Lukasa
Copy link
Member

Lukasa commented Nov 3, 2016

GitHub seems to be super confused: there don't appear to be conflicts in changes.rst as far as I can see. Anyway, I've pushed up those changes and the narrative docs.

@njsmith njsmith merged commit 0f2813f into master Nov 7, 2016
@njsmith njsmith deleted the expose-chunk-delimiters branch July 1, 2017 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants