Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead setuptools links #22

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fix dead setuptools links #22

merged 3 commits into from
Oct 18, 2023

Conversation

James-E-A
Copy link
Contributor

As of Python 3.12, the setuptools documentation is maintained out-of-tree and has been removed from docs.python.org.

@James-E-A
Copy link
Contributor Author

Additional context: https://peps.python.org/pep-0632/

@arigo
Copy link
Contributor

arigo commented Oct 17, 2023

I would use the link https://setuptools.pypa.io/en/stable/userguide/ext_modules.html#building-extension-modules for setuptools_, and remove the link to distutils_ unless you can find documentation about that (so replace the link in the text with a mention like (deprecated in recent versions of Python)).

@@ -94,7 +95,7 @@ In order of complexity:
ext_modules=[foo_build.ffibuilder.distutils_extension()],
)

For Setuptools (out-of-line, but works in ABI or API mode;
For Setuptools (out-of-line only, but works in ABI or API mode;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Correct me if I'm wrong here.)

@arigo arigo merged commit a490b4b into python-cffi:main Oct 18, 2023
53 checks passed
@arigo
Copy link
Contributor

arigo commented Oct 18, 2023

Thanks for the link fixes and the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants