Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow precision specification when bypassing decimal quantization #1058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olunusib
Copy link
Contributor

When bypassing decimal quantization, we should be able to specify precision. Closes #893

Note: This PR is a recreation of the previously closed PR #1010. The original changes were lost due to issues with my previous machine setup. I have re-applied the changes as accurately as possible to maintain the continuity of the work and discussion from PR #1010.

cc @FelixSchwarz @clj @gdiscry

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (e0d1018) to head (8fc6ae4).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   90.99%   91.09%   +0.09%     
==========================================
  Files          26       26              
  Lines        4444     4470      +26     
==========================================
+ Hits         4044     4072      +28     
+ Misses        400      398       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olunusib olunusib force-pushed the feat/decimal-quantization-precision branch from 48c2faa to cf0cf53 Compare January 20, 2024 02:42
@akx akx self-requested a review January 31, 2024 18:59
@akx akx force-pushed the feat/decimal-quantization-precision branch from cf0cf53 to 8fc6ae4 Compare July 11, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format_percent doesn't return trailing decimal zeros with precision
1 participant