Fix attribute collection #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Mar 30, 2020
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
reviewed
Mar 30, 2020
webknjaz
reviewed
Mar 30, 2020
webknjaz
reviewed
Mar 30, 2020
webknjaz
reviewed
Mar 30, 2020
webknjaz
reviewed
Mar 30, 2020
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
underyx
reviewed
Mar 30, 2020
|
This commit doesn't seem to work with slots. See related issue: #667 |
|
This commit is unrelated to #667. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #428 and has pestered me for a long while.
I'm not entirely sure how to go forward with the option, I guess I'll just set it to
Truein@attrs.define?Anyhow, I this is the penultimate ticket stopping me from tackling the new APIs…