Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish our types #7448

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Publish our types #7448

merged 1 commit into from
Jul 5, 2020

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Jul 4, 2020

Fixes #3342. All of the relevant TODOs outlined in #3342 (comment) are covered now so I think we're good to go.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I think I can say for everyone how we are grateful to you for spearing head this effort. 👍

Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bluetech !!

@bluetech bluetech merged commit ef62b86 into pytest-dev:master Jul 5, 2020
@The-Compiler
Copy link
Member

I was about to say "awesome work, I gave it a try with my codebase (qutebrowser) and didn't run into any issues". Then I discovered that mypy was only checking my conftest.py because of missing __init__.py files, and all the rest of my test/ code wasn't ever type-checked (despite --check-untyped-defs. Looks like I have some work to do now! 😅

Either way: Awesome work! 👍

@bluetech bluetech deleted the typing-publish branch July 14, 2020 07:17
ekeih added a commit to ekeih/alerticular that referenced this pull request May 5, 2021
pytest: Update to recent release which includes types thanks to
pytest-dev/pytest#7448

telegram_click_aio: Ignore
aiogram: Ignore
prometheus_async: Ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for static typing
4 participants