explicitly detect conda envs - fixes #12652 #12656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
added
the
backport 8.3.x
2 tasks
initially we accidentially detected conda environmnts by just testing too many files after steamlining we no longer detected conda environments now we explicitly detect conda environments and test for support
RonnyPfannschmidt
force-pushed
the
fix-12652-detect-conda-env
branch
from
bb95a44
to
d0f7884
Compare
nicoddemus
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Awesome, thanks @RonnyPfannschmidt for the quick fix!
Left some very minor suggestions.
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
for more information, see https://pre-commit.ci
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12657 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…da-env (cherry picked from commit 6c806b4)
|
Thanks for the quick turnaround @nicoddemus @RonnyPfannschmidt! |
|
@nicoddemus I didn't yet get around to release Unless something comes up I'd like to run the release after dinner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially we accidentially detected conda environmnts by just testing too many files
after steamlining we no longer detected conda environments
now we explicitly detect conda environments and test for support
@jezdez - i believe this should solve it more future-proof, thanks for the input
Closes #12652