Fix docker #66
Fix docker #66
Conversation
requirements.txt
Outdated
| pyrovision >= 0.1.2 | ||
| python-dotenv >= 0.15.0 | ||
| requests>=2.25.1 | ||
| pyrovision |
There was a problem hiding this comment.
At least a lower bound would be nice don't you think?
There was a problem hiding this comment.
We have an issue with our version number, we get pyrovision--version-.-.-0.1.2a0-288795a therefore the condition pyrovision>xx will always fail
There was a problem hiding this comment.
Mmmh, perhaps I can fix this first then 🤔
There was a problem hiding this comment.
I think this will fix the problem: pyronear/pyro-vision#133
There was a problem hiding this comment.
Thanks ! But I was thinking, maybe it's better to install provision from the repo. We need all the latest updates
There was a problem hiding this comment.
Those are parallel topics (means of installation vs. version specifier), but I'd say:
- we need a version specifier for production repo 😅
- regarding the means of installation, installing from the repo means that if a bug slips in a commit, it will have it. if we put the normal one, we can always install from the repo before running that installation and have the choice. We'll need to make a release of pyrovision soon anyway
What do you think?
There was a problem hiding this comment.
Yes, I see what you mean. I think we need to make a 0.1.3 release and define this version as a minimum to include recent bug fixes.
There was a problem hiding this comment.
can you review the open_fire_v2 PR to include it in the release ?
| pyrovision == 0.1.2 | ||
| pyrovision |
Codecov Report
@@ Coverage Diff @@
## develop #66 +/- ##
========================================
Coverage 68.69% 68.69%
========================================
Files 7 7
Lines 230 230
========================================
Hits 158 158
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
requirements.txt
Outdated
| pyroclient@git+https://github.com/pyronear/pyro-api.git#egg=pyroclient&subdirectory=client | ||
| psutil | ||
| python-dotenv == 0.15.0 |
There was a problem hiding this comment.
can you confirm it can accept spaces around the double equal sign?
There was a problem hiding this comment.
it seems to work but I will remove it just in case
* ci on develop (#68) No code update here, only configuration. I take the liberty to use admin privileges to merge * Code of conduct (#71) * docs: Added code of conduct md file * docs: Updated CONTRIBUTING file, related to code of conduct * Update licence (#70) * nothing * nothing * docs: Updated licence to Apache 2.0 * docs: Updated README * docs: Updated setup.py * chore : added script to check headers script copied from pyro-vision and authored by frgfm * chore : updated folders to check * docs : updated all headers * chore: add ci job to check headers * style : added line at end of file to fix linter * docs: corrected repo starting year in headers & setup * fix version (#73) * pyrovision from repo (#72) * Fix docker (#66) * use pyronear docker hub * issue with pyro-vision version * simplify web server docker * fix versions for production * remove space * add update script (#67) * add update script * add crontab exemple * add monitor runner (#74) * change default loop interval (#75) Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
This PR aims to solve several docker problems in the repo.
Pyro-engine Docker
Web Server Docker