Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added heartbeat at each frame prediction #59

Merged
merged 2 commits into from
Jul 27, 2021
Merged

feat: Added heartbeat at each frame prediction #59

merged 2 commits into from
Jul 27, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jul 22, 2021

This PR simply adds a heartbeat (ping) at each frame prediction when the frame sender is known.

Any feedback is welcome!

@frgfm frgfm added type: enhancement New feature or request webserver labels Jul 22, 2021
@frgfm frgfm added this to the 0.1.0 milestone Jul 22, 2021
@frgfm frgfm requested review from MateoLostanlen and a team July 22, 2021 12:57
@frgfm frgfm self-assigned this Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #59 (764fe00) into master (f271ad6) will decrease coverage by 0.44%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   63.90%   63.46%   -0.45%     
==========================================
  Files          10       10              
  Lines         205      208       +3     
==========================================
+ Hits          131      132       +1     
- Misses         74       76       +2     
Flag Coverage Δ
unittests 63.46% <33.33%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/engine/engine.py 53.42% <33.33%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f271ad6...764fe00. Read the comment docs.

@Akilditu Akilditu self-requested a review July 27, 2021 10:46
Copy link
Collaborator

@Akilditu Akilditu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

This will allow us to report on heartbeats logs and build a dashboard to monitor devices activity.

Quick note : if there is no more heartbeat on one or few pizeros linked to the same tower it means that the issue may be pizero-related. If there is no signal for all pizero on a same tower it means that the issue is more likely related to the main rpi / 4G hotspot.

@frgfm frgfm merged commit 201234c into master Jul 27, 2021
@frgfm frgfm deleted the heartbeat branch July 27, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request webserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants