Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switched console print to logging.info #58

Merged
merged 2 commits into from
Jul 27, 2021
Merged

refactor: Switched console print to logging.info #58

merged 2 commits into from
Jul 27, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jul 22, 2021

This PR introduces the following modifications:

  • reordered imports
  • changed console print to logging.info for a cleaner history of events on the device
  • fixed a comment that was added as a bare string

Any feedback is welcome!

@frgfm frgfm added the type: enhancement New feature or request label Jul 22, 2021
@frgfm frgfm added this to the 0.1.0 milestone Jul 22, 2021
@frgfm frgfm requested review from MateoLostanlen and a team July 22, 2021 12:48
@frgfm frgfm self-assigned this Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #58 (36082ff) into master (ee34cd8) will increase coverage by 0.17%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   63.72%   63.90%   +0.17%     
==========================================
  Files          10       10              
  Lines         204      205       +1     
==========================================
+ Hits          130      131       +1     
  Misses         74       74              
Flag Coverage Δ
unittests 63.90% <57.14%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/pi_utils/reboot_router.py 0.00% <ø> (ø)
pyroengine/engine/engine.py 54.28% <57.14%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee34cd8...36082ff. Read the comment docs.

Copy link
Member

@fe51 fe51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi FG ! Thanks for the PR !

@frgfm frgfm merged commit f271ad6 into master Jul 27, 2021
@frgfm frgfm deleted the logging branch July 27, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants