Add env var for --non-interactive flag #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change --non-interactive action to utils.EnvironmentDefault to support specification as an env var
|
It's definitely overkill to add testing for argparse here. I'd just follow whatever pattern is already used for the other options with environment variables. If they're not tested, then this one doesn't need to be either... and even then, it's probably not needed. I'm happy to accept this as-is. Could you add a changelog entry though? |
|
Doesn't seem like they are, so will update the changelog & open up. Thanks! |
Fixed double colons in recent 3.0 entries
|
Updated the changelog with this PR & retroactively added in #489. Also fixed a couple of the recent entries that were rendering with double colons. |
jaraco
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per review comments in #489, this PR adds support for specifying the
--non-interactiveflag via aTWINE_NON_INTERACTIVEenvironment variable.Opening this up as a draft for comments & also to ask a question on testing: Is it overkill to add testing for
argparse's parsing of the env var as part of Twine?