Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python version specifiers to [core] dependencies #4492

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jul 18, 2024

Summary of changes

Add Python version specifiers to importlib_metadata, importlib_resources and tomli dependencies, to require them only on Python versions on which they are actually used.

Pull Request Checklist

Add Python version specifiers to importlib_metadata, importlib_resources
and tomli dependencies, to require them only on Python versions on which
they are actually used.
@jaraco
Copy link
Member

jaraco commented Jul 21, 2024

Unfortunately, applying this change will almost certainly break the update routine for the vendored packages due to pip not respecting environment markers. If we add these exclusions, we'll also at the very least need to add them to the workaround in that routine. Or perhaps something similar to the upgrade_core could be done to strip the environment markers as a workaround for direct dependencies.

Even better would be to find a solution to pypa/pip#12770; perhaps uv doesn't have that issue and could be used instead.

jaraco added a commit that referenced this pull request Jul 21, 2024
More durable workaround for pypa/pip#12770. Ref #4492.
@jaraco
Copy link
Member

jaraco commented Jul 21, 2024

In 022cedb, I switched to uv for vendoring and it works great, so no longer have any concerns about the markers.

@jaraco jaraco merged commit e3fd44a into pypa:main Jul 21, 2024
21 checks passed
@mgorny mgorny deleted the core-deps-spec branch July 21, 2024 16:19
@mgorny
Copy link
Contributor Author

mgorny commented Jul 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants