Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1509 short-circuit of installing packages when already installed #1510

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

ayemiller
Copy link
Contributor

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Updates logic of install.py to continue installing packages if one is already installed.

Test plan

Added tests to exercise the bug and demonstrate fix:
test_install_three_packages_with_first_already_installed
test_install_two_packages_with_first_two_already_installed

Tested by running

nox -s tests-3.12 -- -k test_install

@ayemiller ayemiller changed the title Fixes short-circuit of installing packages when already installed Issue #1509 short-circuit of installing packages when already installed Aug 17, 2024
@ayemiller ayemiller changed the title Issue #1509 short-circuit of installing packages when already installed Fixes #1509 short-circuit of installing packages when already installed Aug 17, 2024
@chrysle
Copy link
Contributor

chrysle commented Aug 17, 2024

Thanks for catching! Probably, we don't need two tests, though. Besides, the test function names don't really correspond to the actual test procedure..

@chrysle chrysle linked an issue Aug 17, 2024 that may be closed by this pull request
@ayemiller
Copy link
Contributor Author

Thanks for catching! Probably, we don't need two tests, though. Besides, the test function names don't really correspond to the actual test procedure..

Whoops! Updated :)

chrysle
chrysle previously approved these changes Aug 18, 2024
changelog.d/1509.bugfix.md Outdated Show resolved Hide resolved
Co-authored-by: chrysle <96722107+chrysle@users.noreply.github.com>
@Gitznik Gitznik merged commit f7d2564 into pypa:main Aug 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipx install pkg1 pkg2 doesn't install pkg2 if pkg1 already installed
3 participants