Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to title and fix tag name in release action #1437

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

dukecat0
Copy link
Member

@dukecat0 dukecat0 commented Jun 2, 2024

No description provided.

@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

Whee, it worked! Except for the zipapp, which we'll need to upload manually. Done. It's because the output
comes now from the create-tag job (another oversight of mine). Could you amend that?

@dukecat0
Copy link
Member Author

dukecat0 commented Jun 2, 2024

Could you amend that?

Fixed!

@dukecat0 dukecat0 changed the title Add quotes to the title in release action Add quotes to title and fix tag name in release action Jun 2, 2024
@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

Thanks! Don't we also need to specify the new dependency in the needs field?

@dukecat0
Copy link
Member Author

dukecat0 commented Jun 2, 2024

Looks like everthing should work now.

@dukecat0
Copy link
Member Author

dukecat0 commented Jun 2, 2024

Btw, I removed pipx.pyz from release since it doesn't provide the correct version when running pipx --version.

@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

Btw, I removed pipx.pyz from release since it doesn't provide the correct version when running pipx --version.

Ah, right. Uploaded a correctly generated one. I think we need to copy over the job to generate the zipapp then.

@dukecat0
Copy link
Member Author

dukecat0 commented Jun 2, 2024

Or maybe we can generate it by re-running failed jobs:
image

@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

For this time, it's done anyway. For the future, it should be necessary to generate the zipapp directly before uploading to the release – as you pointed out, retrieving it from the preceding tests run results in incorrect version information. Can that be done in this PR?

@dukecat0
Copy link
Member Author

dukecat0 commented Jun 3, 2024

generate the zipapp directly before uploading to the release

Done in the latest commit.

@dukecat0 dukecat0 merged commit 53e527b into main Jun 3, 2024
11 checks passed
@dukecat0 dukecat0 deleted the dukecat0-patch-1 branch June 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants