Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Caching documentation #8780

Merged
merged 2 commits into from
Sep 13, 2020
Merged

Update Caching documentation #8780

merged 2 commits into from
Sep 13, 2020

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Aug 18, 2020

Any headers from serve are ignored. So, this PR remove
the paragraph that mention that. See #8009 and #5670

Close #8009

@eamanu eamanu closed this Aug 19, 2020
@eamanu eamanu reopened this Aug 19, 2020
@eamanu
Copy link
Contributor Author

eamanu commented Aug 19, 2020

I close and reopen the PR because some checks fail.

@eamanu
Copy link
Contributor Author

eamanu commented Aug 19, 2020

ok, errors are repeated

@pradyunsg
Copy link
Member

@eamanu could you rebase this on the current master?

@McSinyx
Copy link
Contributor

McSinyx commented Aug 19, 2020

To quote @uranusjr in another ticket:

Test failures are unrelated, caused by availability issues of http://svn.colorstudy.com.

The whole CI thing doesn't seem to like pip lately 😞

@pradyunsg
Copy link
Member

Which ticket? And which test is this?

@McSinyx
Copy link
Contributor

McSinyx commented Aug 19, 2020

@pradyunsg, it's #8781 (comment). The failures are of tests dealing projects from SVN (which are fetched from the mentioned URL).

@eamanu
Copy link
Contributor Author

eamanu commented Aug 19, 2020

Hi @pradyunsg, the branch is up-to-date with master, thanks

But, like yes @McSinyx seems to be a external error https://github.com/pypa/pip/pull/8780/checks?check_run_id=1001079950

@pradyunsg
Copy link
Member

pradyunsg commented Aug 30, 2020

@eamanu master is green -- try now?

Any headers from serve are ignored. So, this PR remove
the paragraph that mention that. See pypa#8009 and pypa#5670

Close pypa#8009
@eamanu
Copy link
Contributor Author

eamanu commented Sep 7, 2020

@pradyunsg git rebase run :) thanks!

edit: \o/ green!

@pradyunsg pradyunsg added the type: docs Documentation related label Sep 7, 2020
@pradyunsg
Copy link
Member

Hah! Considering how much effort this PR took, I can only infer that removing lines from a codebase really is very difficult. ;)

@pradyunsg pradyunsg merged commit a13f201 into pypa:master Sep 13, 2020
@pradyunsg
Copy link
Member

Thanks @eamanu! ^>^

pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 12, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 12, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 12, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 16, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Caching" section in User Guide
3 participants