Use mypy's default of strict_optional=True #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
changed the title
cjerdonek
added
skip news
|
I like the approach here! Makes it even clearer what our progress in this issue is. :) |
chrahunt
suggested changes
Jul 13, 2019
cjerdonek
force-pushed
the
mypy-per-file-strict-optional
branch
from
6da396f
to
190ea6a
Compare
Closed
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our
setup.cfgto use mypy's default ofstrict_optional=True. Instead, the list of files exempted from this default are explicitly listed. This is nice for a few reasons: (1) files adhering tostrict_optional=Truenow get checked, so it prevents regressions, (2) new files added automatically usestrict_optional=True(because it's the default), and (3) it provides a list that we can see of which files still need to be converted, which gives us an actionable check-list of TODO's.This PR also converts four files over to use
strict_optional(one commit for each one).Refs: #4748 (umbrella issue)