Deprecate setup.py install fallback when wheel package is absent #11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Aug 1, 2022
sbidoul
force-pushed
the
8559-take-2-sbi
branch
from
e67b4fc
to
c12d871
Compare
sbidoul
commented
Aug 2, 2022
src/pip/_internal/req/req_install.py
Outdated
| f"'pyproject.toml' and the 'wheel' package " | ||
| f"is not installed." | ||
| ), | ||
| replacement="to enable the '--use-pep517' option", |
There was a problem hiding this comment.
@pypa/pip-committers what do you think about the suggested replacement. Should we also suggest to install wheel - it is a transitory measure, which is why I did not add it for now, but may also be necessary if using --no-build-isolation.
There was a problem hiding this comment.
I'm inclined not to say install wheel. That's basically implied as an option by the deprecation reason itself. And as you say, it's not the approach we want to encourage.
sbidoul
force-pushed
the
8559-take-2-sbi
branch
from
6773790
to
ae802e3
Compare
uranusjr
approved these changes
Aug 8, 2022
This was referenced Aug 9, 2022
pradyunsg
approved these changes
Aug 9, 2022
|
Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #8102 and #8559.
Restarting #8560.