Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept lowercase doctype declarations #10844

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Accept lowercase doctype declarations #10844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13104a
Accept lowercase doctype declarations
pradyunsg Jan 30, 2022
d028ae5
:newspaper:
pradyunsg Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/10844.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Accept lowercase ``<!doctype html>`` on index pages.
2 changes: 1 addition & 1 deletion src/pip/_internal/index/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
self.anchors: List[Dict[str, Optional[str]]] = []

def handle_decl(self, decl: str) -> None:
if decl != "DOCTYPE html":
if decl.lower() != "doctype html":
self._raise_error()
self._seen_decl = True

Expand Down
2 changes: 1 addition & 1 deletion tests/data/indexes/yanked/simple/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<body>
<a href="../../../packages/simple-1.0.tar.gz">simple-1.0.tar.gz</a>
Expand Down