Skip to content

Commit

Permalink
Quote 'setup.py install' when calling it legacy
Browse files Browse the repository at this point in the history
We want to make it clear that it is the setup.py install command we consider
legacy, not setup.py itself.
  • Loading branch information
sbidoul committed May 31, 2020
1 parent d10c69f commit 95e43e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/pip/_internal/commands/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@ def run(self, options, args):
deprecated(
reason=(
"Could not build wheels for {} which do not use "
"PEP 517. pip will fall back to legacy setup.py "
"install for these.".format(
"PEP 517. pip will fall back to legacy 'setup.py "
"install' for these.".format(
", ".join(r.name for r in legacy_build_failures)
)
),
Expand Down
2 changes: 1 addition & 1 deletion src/pip/_internal/wheel_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _should_build(
if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Using legacy setup.py install for %s, "
"Using legacy 'setup.py install' for %s, "
"since package 'wheel' is not installed.", req.name,
)
return False
Expand Down

0 comments on commit 95e43e3

Please sign in to comment.