override ldshared on non-macos platforms too if CC is overriden #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
reviewed
Sep 16, 2021
There was a problem hiding this comment.
This was introduced in python/cpython@9734568. I don't really understand why this behavior was added as OS X specific, perhaps to avoid changing behavior that nobody reported as an issue?
IMO, this behavior should not be limited to OS X. A quick Google search brings up a stackoverflow question where the user is running into this issue.
https://stackoverflow.com/questions/5986256/python-distutils-gcc-path
@ned-deily what do you think? Do you remember if there was any context we are missing here?
|
LGTM. I'll merge this PR, but if Ned has context to add, please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this was enabled only for macos.
If CC is overriden, then LDSHARED should be overriden to use the same compiler,
otherwise, the compiler used in the compile phase and link phase will be two
different compilers.
cc @FFY00