Make CMSIS pack downloading feature optional #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added a Cargo feature flag to make the CMSIS pack downloading feature optional. But of course I left it enabled by default.
The reason why is because I'm making the next version of my offline firmware programmer tool. I would like to port this library to run it on WebAssembly environment for browser or even port it to ESP32. There are some platforms like these
xtensa-esp32orwasm32-unknowndon't (fully) support for networking and async runtime like Tokio, or they may have binary size constraints. Therefore in order to let this library fits in this scenario, I would like to add in this feature.Regards,
Jackson Hu