Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme file renamed #2357

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

theyashjani
Copy link
Contributor

renamed the readme.rst => README.rst

@theyashjani theyashjani mentioned this pull request Oct 8, 2024
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the reference to readme.rst as well, without that documents cannot be generated

test locally:

cd doc
./build_html

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure document generation works.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm sphinx accept lower case filenames, so it actually works.

@janiversen janiversen merged commit 774c3a7 into pymodbus-dev:dev Oct 8, 2024
13 of 14 checks passed
@janiversen
Copy link
Collaborator

Thanks, it will be available automatically on readthedocs in a couple of minutes (only dev !!!!)

@theyashjani
Copy link
Contributor Author

you need to update the reference to readme.rst as well, without that documents cannot be generated

test locally:

cd doc
./build_html

understood

@theyashjani
Copy link
Contributor Author

Thanks, it will be available automatically on readthedocs in a couple of minutes (only dev !!!!)

sure sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants