Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shutter re-opening after changing config during live mode #344

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

simonecoppola
Copy link
Contributor

@simonecoppola simonecoppola commented Aug 23, 2024

fixes issue with shutter not re-opening

fixes #343

simonecoppola and others added 2 commits August 23, 2024 16:48
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (6c895f3) to head (9cde2a1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          13       13           
  Lines         627      627           
=======================================
  Hits          490      490           
  Misses        137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title Update _core_link.py fix: Update _core_link.py Aug 24, 2024
@tlambert03 tlambert03 changed the title fix: Update _core_link.py fix: changing config during live mode Aug 24, 2024
@tlambert03 tlambert03 changed the title fix: changing config during live mode fix: shutter re-opening after changing config during live mode Aug 24, 2024
Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlambert03 tlambert03 merged commit 31d973d into pymmcore-plus:main Aug 24, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutter not re-opening when channel is changed during live mode
2 participants