Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multiple-statements] Make pylint compatible with black's 2024 style #9697

Merged
merged 3 commits into from
Jun 5, 2024
Merged

[multiple-statements] Make pylint compatible with black's 2024 style #9697

merged 3 commits into from
Jun 5, 2024

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jun 5, 2024 •
edited by jacobtylerwalls
Loading

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #9398

@Pierre-Sassoulas Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.3.x labels Jun 5, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.2.3 milestone Jun 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.83%. Comparing base (57ae027) to head (d985462).
Report is 143 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9697   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files         174      174           
  Lines       18812    18812           
=======================================
  Hits        18028    18028           
  Misses        784      784
Files with missing lines Coverage Ξ”
pylint/checkers/format.py 96.40% <100.00%> (ΓΈ)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on psycopg:
The following messages are no longer emitted:

  1. multiple-statements:
    More than one statement on a single line
    https://github.com/psycopg/psycopg/blob/2bf7783d66ab239a2fa330a842fd461c4bb17c48/psycopg/psycopg/pq/_pq_ctypes.pyi#L11
  2. multiple-statements:
    More than one statement on a single line
    https://github.com/psycopg/psycopg/blob/2bf7783d66ab239a2fa330a842fd461c4bb17c48/psycopg/psycopg/pq/_pq_ctypes.pyi#L17
  3. multiple-statements:
    More than one statement on a single line
    https://github.com/psycopg/psycopg/blob/2bf7783d66ab239a2fa330a842fd461c4bb17c48/psycopg/psycopg/pq/_pq_ctypes.pyi#L18
  4. multiple-statements:
    More than one statement on a single line
    https://github.com/psycopg/psycopg/blob/2bf7783d66ab239a2fa330a842fd461c4bb17c48/psycopg/psycopg/pq/_pq_ctypes.pyi#L19
  5. multiple-statements:
    More than one statement on a single line
    https://github.com/psycopg/psycopg/blob/2bf7783d66ab239a2fa330a842fd461c4bb17c48/psycopg/psycopg/pq/_pq_ctypes.pyi#L20

This comment was generated for commit d985462

DanielNoord
DanielNoord approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@Pierre-Sassoulas Pierre-Sassoulas merged commit afd5edf into pylint-dev:main Jun 5, 2024
48 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the make-pylint-compatible-with-black-2024 branch June 5, 2024 21:42
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
@Pierre-Sassoulas @github-actions
[multiple-statements] Make pylint compatible with black's 2024 style (#…
ab3ac97 
…9697)

* Add more test cases to cover pass / ...
* Define the confidence as HIGH
* Exclude the class with Ellipsis from the check

Closes #9398

(cherry picked from commit afd5edf)
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Pierre-Sassoulas added a commit that referenced this pull request Jun 5, 2024
@github-actions @Pierre-Sassoulas
[multiple-statements] Make pylint compatible with black's 2024 style (#…
192727b 
…9697) (#9698)

* Add more test cases to cover pass / ...
* Define the confidence as HIGH
* Exclude the class with Ellipsis from the check

Closes #9398

(cherry picked from commit afd5edf)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@jacobtylerwalls jacobtylerwalls removed their request for review June 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
backport maintenance/3.3.x False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

Suggestion conflicting with black 2024 style for inlined semantic / empty classes
2 participants
@Pierre-Sassoulas @DanielNoord