Suppress false-positive not-callable messages from class descriptors #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycepg
force-pushed
the
gb
branch
2 times, most recently
from
b166c5e
to
f247f7f
Compare
PCManticore
reviewed
Mar 5, 2018
| @@ -229,3 +229,19 @@ def test_typing_namedtuple_unsubscriptable_object_issue1295(self): | |||
| subscript = module.body[-1].value | |||
| with self.assertNoMessages(): | |||
| self.checker.visit_subscript(subscript) | |||
|
|
|||
| def test_staticmethod_multiprocessing_call(self): | |||
There was a problem hiding this comment.
Can we also add a test with a user-defined descriptor?
There was a problem hiding this comment.
I actually cannot repro elsewhere. descriptors become Uninferable anywhere else due to (https://github.com/PyCQA/astroid/blob/master/astroid/scoped_nodes.py#L2333). Somehow the multiprocessing staticmethod descriptor is getting through with all the magic going on (use of globals, inheritance, all, etc in multiprocessing)
PCManticore
approved these changes
Mar 5, 2018
This is a holdover until astroid can be fixed. Astroid needs to understand descriptors or at least raise Uninferable instead of allowing the descriptor instance through Close pylint-dev#1699
|
Thanks Bryce! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a holdover until astroid can be fixed. Astroid needs to
understand descriptors or at least raise Uninferable instead
of allowing the descriptor instance through
Close #1699