Fix detecting invalid metaclasses #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from pylint-dev#1678
Pull Request Test Coverage Report for Build 3261116685
💛 - Coveralls |
DanielNoord
approved these changes
Oct 17, 2022
| @@ -2841,7 +2841,7 @@ def declared_metaclass( | |||
| return next( | |||
| node | |||
| for node in self._metaclass.infer(context=context) | |||
| if isinstance(node, NodeNG) | |||
| if node is not util.Uninferable | |||
There was a problem hiding this comment.
What values were being rejected by the previous check?
There was a problem hiding this comment.
Oh, never mind: Instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed two failing pylint tests (
invalid_metaclassanddataclass_typecheck) with astroid main. Bisects to #1678.The change hasn't been released yet, so there is no need to backport the fix.
/CC: @DanielNoord
Type of Changes