Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash involving non-standard type comments #1753

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix crash involving non-standard type comments #1753

merged 1 commit into from
Aug 25, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Fixes pylint-dev/pylint#7347.

Type of Changes

Type
✓ 🐛 Bug fix

@DanielNoord DanielNoord added this to the 2.12.4 milestone Aug 25, 2022
@DanielNoord DanielNoord mentioned this pull request Aug 25, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2925275295

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.346%
Totals Coverage Status
Change from base Build 2911362476: 0.001%
Covered Lines: 9713
Relevant Lines: 10518
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit 998ff34 into pylint-dev:main Aug 25, 2022
@DanielNoord DanielNoord deleted the type-comments branch August 25, 2022 09:31
Pierre-Sassoulas pushed a commit that referenced this pull request Aug 25, 2022
@DanielNoord @Pierre-Sassoulas
Fix crash involving non-standard type comments (#1753)
5f04370
Pierre-Sassoulas pushed a commit that referenced this pull request Aug 25, 2022
@DanielNoord @Pierre-Sassoulas
Fix crash involving non-standard type comments (#1753)
d463bd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Crash 💥
Projects
None yet
Milestone
2.12.4
Development

Successfully merging this pull request may close these issues.

[astroid-error] error when checking type comment like 'type: # comment'
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas