Change _get_assign_nodes() to cached_property

pylint-dev · Mar 12, 2023 · 8e463b2 · 8e463b2
1 parent 91fd7b9
commit 8e463b2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/astroid/nodes/_base_nodes.py b/astroid/nodes/_base_nodes.py
@@ -14,7 +14,6 @@
 from collections.abc import Iterator
 from typing import TYPE_CHECKING, ClassVar
 
-from astroid import decorators
 from astroid.exceptions import AttributeInferenceError
 from astroid.nodes.node_ng import NodeNG
 
@@ -196,10 +195,10 @@ def _get_yield_nodes_skip_lambdas(self):
                     continue
                 yield from child_node._get_yield_nodes_skip_lambdas()
 
-    @decorators.cached
+    @cached_property
     def _get_assign_nodes(self):
         children_assign_nodes = (
-            child_node._get_assign_nodes()
+            child_node._get_assign_nodes
             for block in self._multi_line_blocks
             for child_node in block
         )

diff --git a/astroid/nodes/node_classes.py b/astroid/nodes/node_classes.py
@@ -1271,9 +1271,9 @@ def get_children(self):
 
         yield self.value
 
-    @decorators.cached
+    @cached_property
     def _get_assign_nodes(self):
-        return [self] + list(self.value._get_assign_nodes())
+        return [self] + self.value._get_assign_nodes
 
     def _get_yield_nodes_skip_lambdas(self):
         yield from self.value._get_yield_nodes_skip_lambdas()

diff --git a/astroid/nodes/node_ng.py b/astroid/nodes/node_ng.py
@@ -21,7 +21,7 @@
     overload,
 )
 
-from astroid import decorators, util
+from astroid import util
 from astroid.context import InferenceContext
 from astroid.exceptions import (
     AstroidError,
@@ -575,7 +575,7 @@ def nodes_of_class(  # type: ignore[misc] # mypy doesn't correctly recognize the
                 continue
             yield from child_node.nodes_of_class(klass, skip_klass)
 
-    @decorators.cached
+    @cached_property
     def _get_assign_nodes(self):
         return []
 

diff --git a/astroid/nodes/scoped_nodes/scoped_nodes.py b/astroid/nodes/scoped_nodes/scoped_nodes.py
@@ -1434,7 +1434,7 @@ def extra_decorators(self) -> list[node_classes.Call]:
             return []
 
         decorators: list[node_classes.Call] = []
-        for assign in frame._get_assign_nodes():
+        for assign in frame._get_assign_nodes:
             if isinstance(assign.value, node_classes.Call) and isinstance(
                 assign.value.func, node_classes.Name
             ):
@@ -3066,10 +3066,10 @@ def get_children(self):
             yield from self.keywords
         yield from self.body
 
-    @decorators_mod.cached
+    @cached_property
     def _get_assign_nodes(self):
         children_assign_nodes = (
-            child_node._get_assign_nodes() for child_node in self.body
+            child_node._get_assign_nodes for child_node in self.body
         )
         return list(itertools.chain.from_iterable(children_assign_nodes))