Backwards compatible loading of server/executable #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in pyiron/pyiron_atomistics#1531 is caused by the fact that the dictionaries stored for servers/executables in HDF5 changed slightly and I assumed in #1602 that they would always be automatically loaded by the new HasDict functions. But that only works when the newer dictionaries are written, the older representation doesn't have the type information that allows HasDict to automatically load them, so
GenericJob._from_dictassigned the plain dictionaries which then triggered the actual errors seen in CI.With these changes I can load older Calphy and Vasp jobs again.