Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() #1508

jan-janssen · 2024-07-02T16:05:48Z

Example:

from pyiron_base import Project

def add_x_and_y(x, y):
    z = x + y
    return z

def add_x_and_y_and_z(x, y, z):
    w = x + y + z
    return w


pr = Project("test")
z = pr.wrap_python_function(python_function=add_x_and_y, x=1, y=2, delayed=True)
w = pr.wrap_python_function(python_function=add_x_and_y_and_z, x=1, y=2, z=z, delayed=True)
w.result()

Waiting for:

…job' into delayed

for more information, see https://pre-commit.ci

…s is not finished.

# Conflicts: # pyiron_base/project/delayed.py

for more information, see https://pre-commit.ci

…n' into delayed # Conflicts: # pyiron_base/project/generic.py

# Conflicts: # pyiron_base/jobs/flex/executablecontainer.py # pyiron_base/jobs/flex/pythonfunctioncontainer.py # pyiron_base/project/generic.py

for more information, see https://pre-commit.ci

pyiron_base/project/delayed.py

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

pyiron_base/project/delayed.py

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

for more information, see https://pre-commit.ci

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

# Conflicts: # pyiron_base/jobs/job/runfunction.py

pyiron_base/project/delayed.py

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

for more information, see https://pre-commit.ci

jan-janssen · 2024-07-05T06:28:48Z

@samwaseda I would like to include this in the next pyiron_base version. Is there anything missing from your side? Do you have a quick moment to review the latest changes?

samwaseda

There are still some small things I would love to change but they can belong to other PR's.

jan-janssen marked this pull request as draft July 2, 2024 16:05

jan-janssen added the format_black reformat the code using the black standard label Jul 2, 2024

jan-janssen changed the title ~~Delayed execution in pyiron_base - for wrap_python_function() only~~ Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() Jul 2, 2024

jan-janssen added 2 commits July 3, 2024 07:04

Merge remote-tracking branch 'refs/remotes/origin/executablecontainer…

af10665

…job' into delayed

Implement delayed function call

c37e61e

jan-janssen force-pushed the delayed branch from f72bea3 to c37e61e Compare July 3, 2024 05:10

jan-janssen and others added 5 commits July 3, 2024 07:22

Add unit tests

21997c5

[pre-commit.ci] auto fixes from pre-commit.com hooks

dcef45b

for more information, see https://pre-commit.ci

Update draw()

723b6ae

Merge remote-tracking branch 'origin/delayed' into delayed

6831ba5

[pre-commit.ci] auto fixes from pre-commit.com hooks

d9367f8

for more information, see https://pre-commit.ci

jan-janssen requested a review from pmrv July 3, 2024 06:49

jan-janssen and others added 14 commits July 3, 2024 10:16

Ensure keys are strings

b6a91bd

Implement __copy__()

c815ab6

fix copy

75a3b2f

Update delayed.py

bb5941c

run_job_with_status_initialized() - only execute the job if the statu…

1be09af

…s is not finished.

Implement __iter__()

da6a44b

Merge remote-tracking branch 'origin/delayed' into delayed

fa05094

# Conflicts: # pyiron_base/project/delayed.py

[pre-commit.ci] auto fixes from pre-commit.com hooks

d475ecd

for more information, see https://pre-commit.ci

Merge remote-tracking branch 'refs/remotes/origin/wrap_python_functio…

06f6410

…n' into delayed # Conflicts: # pyiron_base/project/generic.py

use getattr()

09b5255

wrap_python_function(): add output_file_lst and output_key_lst

2d53ced

Merge remote-tracking branch 'refs/remotes/origin/main' into delayed

4847804

Merge remote-tracking branch 'refs/remotes/origin/main' into delayed

27687ff

# Conflicts: # pyiron_base/jobs/flex/executablecontainer.py # pyiron_base/jobs/flex/pythonfunctioncontainer.py # pyiron_base/project/generic.py

[pre-commit.ci] auto fixes from pre-commit.com hooks

d3037bf

for more information, see https://pre-commit.ci

jan-janssen mentioned this pull request Jul 4, 2024

ExecutableContainerJob: Fix copying of restart files #1509

Merged

jan-janssen and others added 3 commits July 4, 2024 20:19

Merge remote-tracking branch 'refs/remotes/origin/main' into delayed

e920f69

update test

629bbcd

[pre-commit.ci] auto fixes from pre-commit.com hooks

d8f0b3d

for more information, see https://pre-commit.ci

Add DocStrings

2dd3a75

jan-janssen marked this pull request as ready for review July 4, 2024 19:25

samwaseda reviewed Jul 4, 2024

View reviewed changes

pyiron_base/project/delayed.py Outdated Show resolved Hide resolved

pyiron_base/project/delayed.py Outdated Show resolved Hide resolved

pyiron_base/project/delayed.py Outdated Show resolved Hide resolved

pyiron_base/project/delayed.py Outdated Show resolved Hide resolved

Update pyiron_base/project/delayed.py

6cc64bb

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

samwaseda reviewed Jul 4, 2024

View reviewed changes

pyiron_base/project/delayed.py Outdated Show resolved Hide resolved

jan-janssen and others added 5 commits July 4, 2024 21:39

Update pyiron_base/project/delayed.py

8bd7ee7

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

563efdf

for more information, see https://pre-commit.ci

Update pyiron_base/project/delayed.py

db59ee4

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

Update pyiron_base/project/delayed.py

039ae34

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

Merge remote-tracking branch 'refs/remotes/origin/main' into delayed

c9f89f3

# Conflicts: # pyiron_base/jobs/job/runfunction.py

jan-janssen requested a review from samwaseda July 4, 2024 20:01

samwaseda reviewed Jul 4, 2024

View reviewed changes

jan-janssen and others added 6 commits July 5, 2024 06:21

Update pyiron_base/project/delayed.py

d410c0c

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

Update pyiron_base/project/delayed.py

8c60c50

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

Update pyiron_base/project/delayed.py

cdeaf9d

Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>

Implement separate get_node_name() function

7c24c98

More standalone functions

4a9167a

[pre-commit.ci] auto fixes from pre-commit.com hooks

8c7edf1

for more information, see https://pre-commit.ci

jan-janssen requested a review from samwaseda July 5, 2024 05:39

samwaseda approved these changes Jul 5, 2024

View reviewed changes

jan-janssen merged commit 1efbd7f into main Jul 5, 2024
24 of 25 checks passed

jan-janssen deleted the delayed branch July 5, 2024 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() #1508

Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() #1508

jan-janssen commented Jul 2, 2024 •

edited

Loading

jan-janssen commented Jul 5, 2024

samwaseda left a comment

Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() #1508

Delayed execution in pyiron_base - for wrap_python_function() and wrap_executable() #1508

Conversation

jan-janssen commented Jul 2, 2024 • edited Loading

jan-janssen commented Jul 5, 2024

samwaseda left a comment

Choose a reason for hiding this comment

jan-janssen commented Jul 2, 2024 •

edited

Loading