Database: Extend job_name and project_path to 255 characters #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamhuber
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I guess it should also be updated in _is_valid_job_name and the state update (Weirdly the projectpath column size is already 255 in state update?)
Since this appears in a few places, I suspect it's better to pull it out as a global pyiron_base.database.tables.JOB_COLUMN_WIDTH = 50 or similar and just use it directly. I quickly found the spots above by using my IDE to search for the magic number "50" in pyiron_base files...
jan-janssen
commented
Mar 25, 2024
|
@liamhuber I updated the pull request. Can take another look? I would like to include these changes in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.