Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn if job could not be deleted #1376

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

XzzX
Copy link
Contributor

@XzzX XzzX commented Mar 15, 2024

Since debug messages are not printed by default I think this should be a warning. In particular since it resolves exceptions.

@XzzX XzzX requested a review from jan-janssen March 15, 2024 10:23
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit cd31175 into pyiron:main Mar 19, 2024
22 of 23 checks passed
@XzzX XzzX deleted the warn_if_job_was_not_deleted branch March 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants