Fix multi dimensional arrays with FlattenedStorage.to_pandas #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-janssen
requested changes
Feb 14, 2024
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@pmrv Can you merge |
for more information, see https://pre-commit.ci
Should be fixed now. |
jan-janssen
reviewed
Jul 16, 2024
jan-janssen
reviewed
Jul 16, 2024
Comment on lines
966
to
972
| try: | ||
| dfe = store.to_pandas(explode=True) | ||
| except: | ||
| # Regression test | ||
| self.fail( | ||
| "to_pandas must not fail when multidimensional arrays are present!" | ||
| ) |
There was a problem hiding this comment.
I am a bit confused about the try except part. I agree that it gives a nicer error message but at the same time it is not as readable.
pmrv
commented
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.