Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate removing of jobs by removing consistency check #1326

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

jan-janssen
Copy link
Member

No description provided.

Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with these changes - it is a huge performance bottleneck!
Do we plan to handle cases where a sub-job of a Master is deleted in some way in the database? or do we just say it is not that important, especially with the workflow based pyiron coming up? (Or did I understand something wrong?)

@jan-janssen
Copy link
Member Author

Do we plan to handle cases where a sub-job of a Master is deleted in some way in the database? or do we just say it is not that important, especially with the workflow based pyiron coming up? (Or did I understand something wrong?)

That part is still handled in the remove_job() function.

@niklassiemer
Copy link
Member

Ok, it is handled in JobCore.remove. Then I do not see any issue with this!

@jan-janssen jan-janssen merged commit b33bcac into main Feb 13, 2024
25 checks passed
@jan-janssen jan-janssen deleted the remove_job_exists_check branch February 13, 2024 09:26
@XzzX
Copy link
Contributor

XzzX commented Feb 13, 2024

There is a lot of conversion between job and jobid always involving a database query. Allowing job as an argument to remove_job can reduce the number of database queries even more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants