If JOB_CLASS_DICT contains class return early #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually JOB_CLASS_DICT contains the module path from where to import the class. However Project.create.job/register also supports live classes in there, but this was not handled when loading jobs from HDF again. That code path always expected the module path (as a string) and consequently crashed when it found an object there.
pmrv
added
bug
pmrv
added a commit
that referenced
this pull request
Feb 14, 2024
A refactor in between must have missed renaming the variable that the check is using, essentially making it always False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually JOB_CLASS_DICT contains the module path from where to import the class. However Project.create.job/register also supports live classes in there, but this was not handled when loading jobs from HDF again. That code path always expected the module path (as a string) and consequently crashed when it found an object there.