Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert symmetric ciphers to Rust #9859

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Convert symmetric ciphers to Rust #9859

merged 1 commit into from
Feb 18, 2024

Conversation

alex
Copy link
Member

@alex alex commented Nov 11, 2023

TODO:

@alex alex force-pushed the ciphers-rust branch 4 times, most recently from a4cfd98 to 8e93a60 Compare November 11, 2023 14:13
@alex alex mentioned this pull request Nov 11, 2023
22 tasks
alex added a commit to alex/cryptography that referenced this pull request Nov 11, 2023
reaperhulk pushed a commit that referenced this pull request Nov 11, 2023
@alex alex force-pushed the ciphers-rust branch 2 times, most recently from f32e9dd to 6dcdd74 Compare November 11, 2023 20:39
@alex alex mentioned this pull request Nov 11, 2023
alex added a commit to alex/cryptography that referenced this pull request Nov 11, 2023
@alex alex force-pushed the ciphers-rust branch 6 times, most recently from f14ed65 to ba17a34 Compare November 12, 2023 16:34
@alex alex force-pushed the ciphers-rust branch 3 times, most recently from e21b63b to e396dba Compare November 23, 2023 02:18
@alex alex force-pushed the ciphers-rust branch 5 times, most recently from 802f591 to 53fb74b Compare December 30, 2023 20:11
@jlaine
Copy link
Contributor

jlaine commented Jan 30, 2024

Hi @alex! I'm hitting a deprecation regarding ARC4 when I use this branch, even when I'm not touching ARC4:

>>> from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes
>>> Cipher(algorithm=algorithms.AES(bytes(16)), mode=modes.ECB()).encryptor()
/path/to/env/lib/python3.11/site-packages/cryptography/hazmat/primitives/ciphers/base.py:107: CryptographyDeprecationWarning: ARC4 has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.ARC4 and will be removed from this module in 48.0.0.
  return rust_openssl.ciphers.create_encryption_ctx(

@alex
Copy link
Member Author

alex commented Jan 30, 2024

I haven't updated this branch since @reaperhulk deprecated ARC4, I think types.rs just needs a simple update.

@alex alex force-pushed the ciphers-rust branch 2 times, most recently from b3a9f9c to 05cac43 Compare February 5, 2024 10:51
@alex alex added this to the Forty Third Release milestone Feb 10, 2024
@reaperhulk
Copy link
Member

secdev/scapy#4285 should unblock us here.

@alex alex force-pushed the ciphers-rust branch 3 times, most recently from 43274ff to 06531f7 Compare February 17, 2024 20:15
@alex alex marked this pull request as ready for review February 18, 2024 20:07
@reaperhulk reaperhulk merged commit 50ea0fa into pyca:main Feb 18, 2024
57 checks passed
@alex alex deleted the ciphers-rust branch February 18, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants