Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyblish/pyblish-lite#59, fix pyblish/pyblish-lite#113 #114

Merged
merged 6 commits into from
Nov 13, 2020

Conversation

chadmv
Copy link
Contributor

@chadmv chadmv commented Nov 12, 2020

Reset the iterator to ensure state sync with GUI checkmarks.
Check publish state when processing to skip instances that have been disabled.

Reset the iterator to ensure state sync with GUI checkmarks.
Check publish state when processing to skip instances that have been disabled.
@mottosso
Copy link
Member

Oh snap, is this it? 4 years of getting emails about this not working xD Thanks for this.

It's unclear why Travis is taking so long, I tried restarting it but it's still hung up. I'll leave this overnight to see whether it just needs a really long time.

@chadmv
Copy link
Contributor Author

chadmv commented Nov 12, 2020

It seemed pretty straightforward. I had to double check everything because the fix seemed relatively simple. But it solved my issue in #113 and fixed the test case presented in #59

@mottosso
Copy link
Member

Nice one.

Because this is at risk of affecting the behavior of publishing, I'll release this as a "beta" initially to allow users to test it using:

pip install pyblish-lite
# pyblish_lite-0.8.7 installed

pip install pyblish-lite --pre --upgrade
# pyblish_lite-0.8.8b1 installed

@mottosso mottosso merged commit ca89c50 into pyblish:master Nov 13, 2020
RafaelVillar added a commit to RafaelVillar/pyblish-lite that referenced this pull request Jan 29, 2021
mottosso added a commit that referenced this pull request Feb 1, 2021
reset_iterator starts from the first validatorOrder value #114 #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants