Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle instance should effect instance plugins #20

Open
larsbijl opened this issue May 13, 2016 · 5 comments
Open

Toggle instance should effect instance plugins #20

larsbijl opened this issue May 13, 2016 · 5 comments
Assignees

Comments

@larsbijl
Copy link
Member

goal

When I toggle a instance in the left hand side it should toggle on/off the relevant instance plugins on the right hand side of the overview.

implementation

A good place would be in control.py, under the on_toggle method

@larsbijl larsbijl self-assigned this May 13, 2016
@mottosso
Copy link
Member

In QML, what happens is that the unsupported plug-ins disappear; to only display those that actually get run/are optional.

Unchecking them is a good first step, having them disappear is more complex and can come afterwards.

As a detail, it should probably both uncheck and make it non-optional so the user can't check it afterwards. Running it does nothing, but it'd color it green which might be confusing.

@larsbijl
Copy link
Member Author

larsbijl commented May 16, 2016

maybe we can just make the text gray making it look inactive instead of fully removing it?

@mottosso
Copy link
Member

We could, but the benefit of hiding them is that there could be hundreds of registered plug-ins, but the user (and developer) would only ever see relevant ones.

In QML, and here, I think it could be advantageous to have an option to toggle this behaviour, as it can sometimes be useful to see exactly everything that is available, for debugging purposes.

@mkolar
Copy link
Member

mkolar commented May 20, 2016

I personally really like the hiding behavior. It makes it very clear what is about to be ran, so ultimately it would be nice to get to that eventually.

@BigRoy
Copy link
Member

BigRoy commented May 20, 2016

I personally really like the hiding behavior. It makes it very clear what is about to be ran, so ultimately it would be nice to get to that eventually.

+1

tokejepsen pushed a commit to tokejepsen/pyblish-lite that referenced this issue May 22, 2020
…o_overview

feature/PYPE-376_switch_to_overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants