Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register plugin path issues #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannesdelbeke
Copy link
Contributor

@hannesdelbeke hannesdelbeke commented Jan 17, 2022

created a register path test while working on previous PR
and noticed odd behaviour, described in issue #379

this new test influences test behaviour of unrelated tests

in py2 and py3
a test that should fail or be skipped, does not run
This came to my attention while working on pathlib deregister support #384 .
The deregister path test stopped running when adding this new binary string test.
The test is not skipped, and did not fail, it inexplicably wasn't picked up by nose.
When removing the new test commited in this PR it worked again.

we can see this reflected in the logs https://ci.appveyor.com/project/mottosso/pyblish/builds/42230403/job/oefioqph7sbsnbqn
pathlib deregister test does not run

issue when using binary string to register plugin paths

in py 3
binary string fails in py3+

register the following path

u"c:\some\special\södär\testpath".encode('utf-8')

results in failed test
AssertionError: b'c:\some\special\s\xc3\xb6d\xc3\xa4r\testpath' not in ['C:\\projects\\pyblish\\pyblish\\plugins', 'server\\plugins', b'c:\\some\\special\\s\xc3\xb6d\xc3\xa4r\testpath']

see old PR #383 for more info

binary string atm fails in py3+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant