Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove cython stuff #66

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

tlambert03
Copy link
Member

closes #65

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (185fab8) 100.00% compared to head (b0c20bd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          522       521    -1     
=========================================
- Hits           522       521    -1     
Impacted Files Coverage Δ
src/in_n_out/_util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 5, 2023

CodSpeed Performance Report

Merging #66 will degrade performances by 15.73%

Comparing tlambert03:remove-cython (b0c20bd) with main (185fab8)

Summary

❌ 2 (👁 2) regressions
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark main tlambert03:remove-cython Change
👁 test_time_run_process 179.6 µs 213.1 µs -15.73%
👁 test_time_run_inject_and_process 479 µs 568.2 µs -15.7%

@tlambert03 tlambert03 merged commit 8ac8675 into pyapp-kit:main Jul 6, 2023
20 checks passed
@tlambert03 tlambert03 deleted the remove-cython branch July 6, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen cython reqs
1 participant