Merge pull request #21 from LiamGoodacre/fix/simplify-bounded-either

Simplify toEnum for Either instance.
purescript · Nov 10, 2016 · 3b6c084 · 3b6c084
2 parents dc6bbed + 73e6c20
commit 3b6c084
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/Data/Enum.purs b/src/Data/Enum.purs
@@ -203,13 +203,12 @@ instance boundedEnumEither :: (BoundedEnum a, BoundedEnum b) => BoundedEnum (Eit
     Cardinality
       $ unwrap (cardinality :: Cardinality a)
       + unwrap (cardinality :: Cardinality b)
-  toEnum n = to cardinality cardinality
+  toEnum n = to cardinality
     where
-    to :: Cardinality a -> Cardinality (Either a b) -> Maybe (Either a b)
-    to (Cardinality ca) (Cardinality cab)
+    to :: Cardinality a -> Maybe (Either a b)
+    to (Cardinality ca)
       | n >= 0 && n < ca = Left <$> toEnum n
-      | n >= ca && n < cab = Right <$> toEnum (n - ca)
-      | otherwise = Nothing
+      | otherwise = Right <$> toEnum (n - ca)
   fromEnum (Left a) = fromEnum a
   fromEnum (Right b) = fromEnum b + unwrap (cardinality :: Cardinality a)