Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametrize xtradb package name #860

Merged
merged 3 commits into from
Jul 1, 2016

Conversation

ndelic0
Copy link
Contributor

@ndelic0 ndelic0 commented Jun 28, 2016

This is a new pull request as the previous one could not be squashed before fixing the conflict.

@tphoney
Copy link
Contributor

tphoney commented Jun 28, 2016

The travisci errors are known (working on them now), what PR was this based on @ndelic0 ?

@ndelic0
Copy link
Contributor Author

ndelic0 commented Jun 28, 2016

#843

@ndelic0
Copy link
Contributor Author

ndelic0 commented Jul 1, 2016

@tphoney travisci errors are gone.Hope this pull req is ok now?

@tphoney
Copy link
Contributor

tphoney commented Jul 1, 2016

@ndelic0 you mentioned in the previous pull request, that you are making this change because of https://bugs.launchpad.net/percona-xtrabackup/+bug/1568049 and that you were going to set the package name like percona-xtrabackup-2{1..4} to specify version. In reality it is better to specify the version with https://docs.puppet.com/puppet/latest/reference/types/package.html#package-attribute-ensure. @DavidS any further comment ?

@ndelic0
Copy link
Contributor Author

ndelic0 commented Jul 1, 2016

@tphoney I'm referring to name var here - package name :

Available Packages
Name        : percona-xtrabackup
Arch        : x86_64
Version     : 2.3.4
Release     : 1.el6


Name        : percona-xtrabackup-21
Arch        : x86_64
Version     : 2.1.9
Release     : 746.rhel6

Name        : percona-xtrabackup-22
Arch        : x86_64
Version     : 2.2.13
Release     : 1.el6

I

@tphoney
Copy link
Contributor

tphoney commented Jul 1, 2016

thanks for the further information

@DavidS DavidS merged commit 041ef06 into puppetlabs:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants