Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource fails when fqdn is not set. #853

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Conversation

ragonlan
Copy link
Contributor

@ragonlan ragonlan commented Jun 7, 2016

if server don't have domain name facter don't initialize fqdn and mysql_user resource fails with "...Invalid database user..." error.

if server don't have domain name facter don't initialize fqdn and mysql_user resource fails with "...Invalid database user..." error.
@igalic
Copy link
Contributor

igalic commented Jun 14, 2016

@ragonlan i'm confused. why would your servers not have an fqdn??

@ragonlan
Copy link
Contributor Author

Sorry it was a bug in old facter versions (previous to 2.1.0-1puppetlabs1) fqdn is not defined unless host and domain is defined:

    if host and domain
      [host, domain].join(".")
    else
      nil
    end

it is fixed in current version with:

     if host and domain
       [host, domain].join(".")
     elsif host
       host
     else
       nil
     end

but official version from ubuntu 14.04 (facter=1.7.5-1ubuntu1) is affected.

@igalic igalic merged commit 5bd4975 into puppetlabs:master Jun 15, 2016
@igalic
Copy link
Contributor

igalic commented Jun 15, 2016

thank you very much @ragonlan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants