Fix when not managing config file #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no test with |
|
@mcanevet hint hint nudge nudge |
|
That unit test will succeed even without the change. |
|
@DavidS it should fail when using STRICT_VARIABLES="yes", no? |
|
Ah yes, you are, of course correct. Can you squash this into a single commit, so we can merge this? |
This code have been remove here puppetlabs@4bab65e#diff-0938042fe2382aeb10032aa7f8444995 but it is required otherwise we get an `Evaluation Error: Unknown variable: 'install_db_args'.` when using `manage_config_file = false`
|
@DavidS done |
igalic
added a commit
that referenced
this pull request
Sep 22, 2015
Fix when not managing config file
|
thanks everyone \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code have been remove here 4bab65e#diff-0938042fe2382aeb10032aa7f8444995 but it is required otherwise we get an
Evaluation Error: Unknown variable: 'install_db_args'.when usingmanage_config_file = false