Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in 578 #671

Merged
merged 1 commit into from
Feb 16, 2015
Merged

Fix bug in 578 #671

merged 1 commit into from
Feb 16, 2015

Conversation

aldavud
Copy link
Contributor

@aldavud aldavud commented Feb 12, 2015

the recently added feature to support galera by allowing independent
creation of the root@localhost user in the DB and the /root/.my.cnf
file contains a bug.

specifically the .my.cnf file resource still requires the root@localhost
resource, even when it is not available.

this fixes the issue by making the dependency optional.

@aldavud aldavud changed the title Fix bug in GH-578 Fix bug in 578 Feb 12, 2015
@igalic
Copy link
Contributor

igalic commented Feb 16, 2015

@aldavud would you very much mind squashing those two commits?

the recently added feature to support galera by allowing independent
creation of the root@localhost user in the DB and the /root/.my.cnf
file contains a bug.

specifically the .my.cnf file resource still requires the root@localhost
resource, even when it is not available.

this fixes the issue by making the dependency conditional.
@aldavud
Copy link
Contributor Author

aldavud commented Feb 16, 2015

There you go...

igalic added a commit that referenced this pull request Feb 16, 2015
@igalic igalic merged commit 3f18713 into puppetlabs:master Feb 16, 2015
@igalic
Copy link
Contributor

igalic commented Feb 16, 2015

thanks @aldavud!

@aldavud aldavud deleted the fix-bug-in-578 branch February 16, 2015 20:32
@aldavud
Copy link
Contributor Author

aldavud commented Feb 16, 2015

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants