Return an empty string for an empty input. #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,7 @@ module Puppet::Parser::Functions | |||
| raise(Puppet::ParseError, 'mysql_password(): Wrong number of arguments ' + | |||
| "given (#{args.size} for 1)") if args.size != 1 | |||
|
|
|||
| '*' + Digest::SHA1.hexdigest(Digest::SHA1.digest(args[0])).upcase | |||
| # Return the hash or an empty string for an empty argument | |||
| args[0].length > 0 ? '*' + Digest::SHA1.hexdigest(Digest::SHA1.digest(args[0])).upcase : '' | |||
There was a problem hiding this comment.
return '' if args[0].empty?
'*' + Digest::SHA1.hexdigest(Digest::SHA1.digest(args[0])).upcase
endstrikes me as more readable/rubylike.
(and doesn't need a comment to explain what it does ;)
https://tickets.puppetlabs.com/browse/MODULES-1676 This is identical to what PASSWORD('') in MySQL does: 5.6.22-debug-log> CREATE USER 'testpwd'@'localhost' IDENTIFIED BY 'foo'; Query OK, 0 rows affected (0.03 sec) 5.6.22-debug-log> SELECT User,Host,Password FROM mysql.user WHERE User='testpwd'; +---------+-----------+-------------------------------------------+ | User | Host | Password | +---------+-----------+-------------------------------------------+ | testpwd | localhost | *F3A2A51A9B0F2BE2468926B4132313728C250DBF | +---------+-----------+-------------------------------------------+ 1 row in set (0.01 sec) 5.6.22-debug-log> SET PASSWORD FOR 'testpwd'@'localhost' = PASSWORD(''); Query OK, 0 rows affected (0.00 sec) 5.6.22-debug-log> SELECT User,Host,Password FROM mysql.user WHERE User='testpwd'; +---------+-----------+----------+ | User | Host | Password | +---------+-----------+----------+ | testpwd | localhost | | +---------+-----------+----------+ 1 row in set (0.00 sec)
hunner
added a commit
that referenced
this pull request
Feb 5, 2015
Return an empty string for an empty input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-1676
This is identical to what PASSWORD('') in MySQL does: