Reworked all identifier quoting detections #612

lavoiesl · 2014-11-27T17:50:44Z

Otherwise, trying to manage debian-sys-maint will fail miserably, quoted or not.

Now:

Proper quoting detection using backreferences.
Outputs the offending character when it is detected.
Clearer and more robust detection overall.

Fixes #609

NB: I am not very experienced with Ruby and this is my first time using rspec, comments are welcomed.

Otherwise, trying to manage `debian-sys-maint` will fail miserably, quoted or not. Fixes #609

lavoiesl · 2014-11-27T17:53:05Z

lib/puppet/type/mysql_grant.rb

+        host_part = matches[3]
+      elsif matches = /^([0-9a-zA-Z$_]+)@([\w%\.:]+)$/.match(value)
+        user_part = matches[1]
+        host_part = matches[2]


host_part is not used, but I figured someone could eventually do some better checks on it as well.

Reworked all identifier quoting detections

The regex updates caused failures in some places where it previously (correctly) worked.

Fix issues introduced in #612

3f18713 Merge pull request #671 from aldavud/fix-bug-in-578 b3c33f0 fix bug in GH-578 efa2f58 Merge pull request #673 from cmurphy/lint d6b1642 Fix lint warnings and ensure lint fails on warnings b64ca51 Merge pull request #669 from dveeden/lint-fix f2bfe9e Fix rake lint error in examples/server/config.php 7e81906 Merge pull request #668 from mhaskel/merge_3.2.x_to_master f93fbe3 Merge pull request #667 from mhaskel/tests_to_examples d665e8f move tests to examples a51b983 Merge pull request #664 from mhaskel/3.2.0-prep 8397805 Merge pull request #665 from mhaskel/lint_fixes 9f84ef7 3.2.0 prep 2635469 lint cleanup b9fbba3 Merge pull request #578 from franzs/new_root_options b6ab888 Merge pull request #661 from mhaskel/MODULES-1759 96f4d16 MODULES-1759: Remove dependency on stdlib >=4.1.0 b57191f Merge pull request #655 from rnelson0/remove_provider 14d5813 Merge pull request #660 from hunner/bump_stdlib 8a828aa Bugfix: increase minimum stdlib b3a38a8 Merge pull request #645 from dveeden/auth-plugins dc23fed Merge pull request #658 from hunner/fix_grant 506292a Make grant autorequire user 3fa7050 Merge pull request #646 from dveeden/emptypwd fa66b38 Merge pull request #657 from cmurphy/rspec 1394bd9 Pin rspec gems 9192a9d Merge pull request #656 from puppetlabs/revert-651-bug/master/root_account_fix 77b7dba Revert "(#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to depe..." a839489 Merge pull request #651 from lodgenbd/bug/master/root_account_fix e08aa01 (MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance. 279c13b Return an empty string for an empty input. b98c056 Merge pull request #652 from casharma/no_more_init 2a17e54 there is no class called mysql anymore (to test) c9c5eb3 (#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to dependency 74e1969 Merge pull request #650 from cmurphy/fix_fix_tests 551d22f Fix acceptance tests from #648 d5defe2 Merge pull request #648 from cmurphy/fix_tests 80236d1 Fix acceptance tests from #641 8dbe7c0 Merge pull request #641 from dveeden/plugin 74132ec Add type & provider for managing plugins 367fcf0 Support authentication plugins 0623654 Merge pull request #644 from puppetlabs/revert-640-auth-plugins ccf37e7 Revert "Support for authentication plugins" 1a87bae Merge pull request #637 from dveeden/account_localhost 9a613bb Merge pull request #638 from dveeden/doc-secure bcb6150 Merge pull request #640 from dveeden/auth-plugins c04fed1 When fqdn==localhost account security breaks 305b0d2 Support authentication plugins d45b6a8 Make sure the example is somewhat secure 9f5539c Merge pull request #639 from juniorsysadmin/fix-service-lint-warning 2088fb8 Fix lint warning in server/service.pp 23c192d Merge pull request #634 from cyberious/ResourceTest 8d7ab1d Merge pull request #635 from mhaskel/MODULES-1520 d9d0271 MODULES-1520 add test to assert it does not break f92a24e MODULES-1520 - update username validation 4203867 Merge pull request #632 from mhaskel/future_parser_fix b20f043 Future parser fix in params.pp efeb01c Merge pull request #631 from cmurphy/master 83e87f5 Add IntelliJ files to the ignore list d3f7254 Merge pull request #616 from takumin/install_db_with_freebsd 5f62e6d Merge pull request #615 from KlavsKlavsen/master 457194c Merge pull request #629 from pishro-oss/master 263a9fa useless whitespace removed 9f9061e under Debian 8 package name for ruby mysql biding is called ruby-mysql, just like trusty. ea7d66a Merge pull request #628 from mhaskel/merge_3.1.x_into_master 09325e6 Merge pull request #627 from mhaskel/metadata_fix b12890d Forgot to add SLES12 to metadata. yay. bb12e9d Merge pull request #626 from mhaskel/3.1.0-prep c7f179d 3.1.0 prep 120e6b1 Merge pull request #625 from mhaskel/lint_cleanup a367b3e Clean up lint warnings 407e869 Merge pull request #624 from mhaskel/FM-2112 3c872ab Remove mysqltuner, fetch with staging instead 468986d Merge pull request #623 from mhaskel/FM-2111 a611686 Fix issues introduced in puppetlabs/puppetlabs-mysql#612 2f9820c Merge pull request #622 from mhaskel/puppet_not_shell 9361545 Use puppet() instead of shell() to install module dependencies aeb5ae5 Merge pull request #612 from lavoiesl/identifier-quoting 8e24162 Merge pull request #619 from cmurphy/master e8708f2 Add json gem 638b9c5 Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md 619fa7c Merge pull request #618 from cmurphy/sync 94448f3 Remove mime-types from .sync.yml 7d3962f mysql_install_db freebsd support a8fd4d3 ensure mysql-config-file and server package is in place before trying to start service - to ensure it gets started with correct settings and does not try to enable service before it actually exists :) 67bf7a3 Merge pull request #613 from justinstoller/maint/master/update-for-geppetto f0f5f64 Update for using Geppetto plugin in CI 60838a5 Reworked all identifier quoting detections f235f34 Merge pull request #611 from cmurphy/sles12 e23da83 Fix operating system release fact for SLES 137d0db Merge pull request #610 from cmurphy/sles12 25b6534 Add support for SLES 12 e0e797e Revert "Default to MariaDB for SLES 12" 510dfda Merge pull request #607 from laurenrother/summary 5a0ad6d Merge pull request #608 from cyberious/SLES12 8cc0083 Default to MariaDB for SLES 12 790305b Merge pull request #606 from michaeltchapman/usernameregex cfec01f Add metadata summary per FM-1523 fe0365e Support size 15 and 16 quoted usernames 31191b6 Merge pull request #604 from mhaskel/rebase_581 b7feb95 Merge pull request #605 from slamont/master 3b5d5af Proper containment for mysql::client in mysql::db 473a3c3 Fixed test classes 18265e0 Merge pull request #603 from mhaskel/mysql_test_fixes 11fb01c Fix test issues ab84a67 Merge pull request #574 from Mylezeem/allow_multiple_import_at_a_time 22b07ae Merge pull request #602 from theasci/fix-user-validation-regression 4f0d431 Fix regression in username validation 5e6a1c4 (MODULES-1338) Allow mysql::db to import several files 89762a7 Merge pull request #601 from mhaskel/merge_3.0.x 56e52fc Merge pull request #596 from NoodlesNZ/logbindir b06d3fe Merge remote-tracking branch 'upstream/3.0.x' into merge_3.0.x 08a66b7 Added log-bin dir creatation ad709af Merge pull request #591 from damonconway/MODULES-1484 810ceb1 Merge pull request #600 from hunner/release_3.0.0 46c53db clarify changelog for major release c5c1b38 Prepare for 3.0.0 release e5a300a Merge pull request #599 from mhaskel/metadata_fix 67bae9f Fix issues URL and make format match puppet module build 45b4f4b Merge pull request #598 from mhaskel/fix_for_beaker_with_1.8.7 0aee5c9 Prior to this there was generic :test group. 7de2316 [MODULES-1484] Add support for install_options for all package resources. 8dd37ae Merge pull request #594 from skroll/escape_backslash 1494412 Merge pull request #588 from maxenced/fix-mysql-user-allowed-char cdd7132 Improve checks for MySQL user's name. d9e5c95 Merge pull request #593 from vinzent/small_maint 9dbdd89 Fix escaped backslashes in grants 5d732bd (maint) add statement "MANAGED BY PUPPET" to my.cnf config file template and remove unused my.conf.cnf.erb template 02564bf Add new parameters create_root_user and create_root_my_cnf. Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>

037d30d Merge pull request #677 from mhaskel/fix_for_654 b630eca Merge pull request #675 from jbondpdx/readme-rev c1191f1 PR 654 was incorrectly using stdlib dirname e323f69 Merge pull request #654 from NoodlesNZ/logbindir 2635e1a DOC-1491: fixed typo 97f3ac7 DOC-1491: Add'l updated on revision; new params updated. 91d1077 DOC-1491: Major revision mysql module readme efcf2ed Merge pull request #674 from cyberious/LintFixes 51d66a5 Fix lint issues due to merging of PR #649 cb142f4 Merge pull request #649 from dveeden/newbackupprovider 3f18713 Merge pull request #671 from aldavud/fix-bug-in-578 b3c33f0 fix bug in GH-578 efa2f58 Merge pull request #673 from cmurphy/lint d6b1642 Fix lint warnings and ensure lint fails on warnings 58508b7 Use backup providers dc71156 Check for full path for log-bin to stop puppet from managing directory “.” b64ca51 Merge pull request #669 from dveeden/lint-fix f2bfe9e Fix rake lint error in examples/server/config.php 7e81906 Merge pull request #668 from mhaskel/merge_3.2.x_to_master f93fbe3 Merge pull request #667 from mhaskel/tests_to_examples d665e8f move tests to examples a51b983 Merge pull request #664 from mhaskel/3.2.0-prep 8397805 Merge pull request #665 from mhaskel/lint_fixes 9f84ef7 3.2.0 prep 2635469 lint cleanup b9fbba3 Merge pull request #578 from franzs/new_root_options b6ab888 Merge pull request #661 from mhaskel/MODULES-1759 96f4d16 MODULES-1759: Remove dependency on stdlib >=4.1.0 b57191f Merge pull request #655 from rnelson0/remove_provider 14d5813 Merge pull request #660 from hunner/bump_stdlib 8a828aa Bugfix: increase minimum stdlib b3a38a8 Merge pull request #645 from dveeden/auth-plugins dc23fed Merge pull request #658 from hunner/fix_grant 506292a Make grant autorequire user 3fa7050 Merge pull request #646 from dveeden/emptypwd fa66b38 Merge pull request #657 from cmurphy/rspec 1394bd9 Pin rspec gems 9192a9d Merge pull request #656 from puppetlabs/revert-651-bug/master/root_account_fix 77b7dba Revert "(#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to depe..." a839489 Merge pull request #651 from lodgenbd/bug/master/root_account_fix e08aa01 (MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance. 279c13b Return an empty string for an empty input. b98c056 Merge pull request #652 from casharma/no_more_init 2a17e54 there is no class called mysql anymore (to test) c9c5eb3 (#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to dependency 74e1969 Merge pull request #650 from cmurphy/fix_fix_tests 551d22f Fix acceptance tests from #648 d5defe2 Merge pull request #648 from cmurphy/fix_tests 80236d1 Fix acceptance tests from #641 8dbe7c0 Merge pull request #641 from dveeden/plugin 74132ec Add type & provider for managing plugins 367fcf0 Support authentication plugins 0623654 Merge pull request #644 from puppetlabs/revert-640-auth-plugins ccf37e7 Revert "Support for authentication plugins" 1a87bae Merge pull request #637 from dveeden/account_localhost 9a613bb Merge pull request #638 from dveeden/doc-secure bcb6150 Merge pull request #640 from dveeden/auth-plugins c04fed1 When fqdn==localhost account security breaks 305b0d2 Support authentication plugins d45b6a8 Make sure the example is somewhat secure 9f5539c Merge pull request #639 from juniorsysadmin/fix-service-lint-warning 2088fb8 Fix lint warning in server/service.pp 23c192d Merge pull request #634 from cyberious/ResourceTest 8d7ab1d Merge pull request #635 from mhaskel/MODULES-1520 d9d0271 MODULES-1520 add test to assert it does not break f92a24e MODULES-1520 - update username validation 4203867 Merge pull request #632 from mhaskel/future_parser_fix b20f043 Future parser fix in params.pp efeb01c Merge pull request #631 from cmurphy/master 83e87f5 Add IntelliJ files to the ignore list d3f7254 Merge pull request #616 from takumin/install_db_with_freebsd 5f62e6d Merge pull request #615 from KlavsKlavsen/master 457194c Merge pull request #629 from pishro-oss/master 263a9fa useless whitespace removed 9f9061e under Debian 8 package name for ruby mysql biding is called ruby-mysql, just like trusty. ea7d66a Merge pull request #628 from mhaskel/merge_3.1.x_into_master 09325e6 Merge pull request #627 from mhaskel/metadata_fix b12890d Forgot to add SLES12 to metadata. yay. bb12e9d Merge pull request #626 from mhaskel/3.1.0-prep c7f179d 3.1.0 prep 120e6b1 Merge pull request #625 from mhaskel/lint_cleanup a367b3e Clean up lint warnings 407e869 Merge pull request #624 from mhaskel/FM-2112 3c872ab Remove mysqltuner, fetch with staging instead 468986d Merge pull request #623 from mhaskel/FM-2111 a611686 Fix issues introduced in puppetlabs/puppetlabs-mysql#612 2f9820c Merge pull request #622 from mhaskel/puppet_not_shell 9361545 Use puppet() instead of shell() to install module dependencies aeb5ae5 Merge pull request #612 from lavoiesl/identifier-quoting 8e24162 Merge pull request #619 from cmurphy/master e8708f2 Add json gem 638b9c5 Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md 619fa7c Merge pull request #618 from cmurphy/sync 94448f3 Remove mime-types from .sync.yml 7d3962f mysql_install_db freebsd support a8fd4d3 ensure mysql-config-file and server package is in place before trying to start service - to ensure it gets started with correct settings and does not try to enable service before it actually exists :) 67bf7a3 Merge pull request #613 from justinstoller/maint/master/update-for-geppetto f0f5f64 Update for using Geppetto plugin in CI 60838a5 Reworked all identifier quoting detections f235f34 Merge pull request #611 from cmurphy/sles12 e23da83 Fix operating system release fact for SLES 137d0db Merge pull request #610 from cmurphy/sles12 25b6534 Add support for SLES 12 e0e797e Revert "Default to MariaDB for SLES 12" 510dfda Merge pull request #607 from laurenrother/summary 5a0ad6d Merge pull request #608 from cyberious/SLES12 8cc0083 Default to MariaDB for SLES 12 790305b Merge pull request #606 from michaeltchapman/usernameregex cfec01f Add metadata summary per FM-1523 fe0365e Support size 15 and 16 quoted usernames 31191b6 Merge pull request #604 from mhaskel/rebase_581 b7feb95 Merge pull request #605 from slamont/master 3b5d5af Proper containment for mysql::client in mysql::db 473a3c3 Fixed test classes 18265e0 Merge pull request #603 from mhaskel/mysql_test_fixes 11fb01c Fix test issues ab84a67 Merge pull request #574 from Mylezeem/allow_multiple_import_at_a_time 22b07ae Merge pull request #602 from theasci/fix-user-validation-regression 4f0d431 Fix regression in username validation 5e6a1c4 (MODULES-1338) Allow mysql::db to import several files 89762a7 Merge pull request #601 from mhaskel/merge_3.0.x 56e52fc Merge pull request #596 from NoodlesNZ/logbindir b06d3fe Merge remote-tracking branch 'upstream/3.0.x' into merge_3.0.x 08a66b7 Added log-bin dir creatation ad709af Merge pull request #591 from damonconway/MODULES-1484 810ceb1 Merge pull request #600 from hunner/release_3.0.0 46c53db clarify changelog for major release c5c1b38 Prepare for 3.0.0 release e5a300a Merge pull request #599 from mhaskel/metadata_fix 67bae9f Fix issues URL and make format match puppet module build 45b4f4b Merge pull request #598 from mhaskel/fix_for_beaker_with_1.8.7 0aee5c9 Prior to this there was generic :test group. 7de2316 [MODULES-1484] Add support for install_options for all package resources. 8dd37ae Merge pull request #594 from skroll/escape_backslash 1494412 Merge pull request #588 from maxenced/fix-mysql-user-allowed-char cdd7132 Improve checks for MySQL user's name. d9e5c95 Merge pull request #593 from vinzent/small_maint 9dbdd89 Fix escaped backslashes in grants 5d732bd (maint) add statement "MANAGED BY PUPPET" to my.cnf config file template and remove unused my.conf.cnf.erb template 02564bf Add new parameters create_root_user and create_root_my_cnf.

60c0bfb Merge pull request #679 from elricsfate/master 7a3fe1c Merge pull request #617 from juniorsysadmin/package-manage-parameter a1eca5f Modified Line 49 and 220 to fix broken links 7eea731 Merge pull request #678 from hunner/fix_logerror ce43899 (MODULES-1804) Allow override of log-error 037d30d Merge pull request #677 from mhaskel/fix_for_654 b630eca Merge pull request #675 from jbondpdx/readme-rev c1191f1 PR 654 was incorrectly using stdlib dirname e323f69 Merge pull request #654 from NoodlesNZ/logbindir 2635e1a DOC-1491: fixed typo 97f3ac7 DOC-1491: Add'l updated on revision; new params updated. 91d1077 DOC-1491: Major revision mysql module readme efcf2ed Merge pull request #674 from cyberious/LintFixes 51d66a5 Fix lint issues due to merging of PR #649 cb142f4 Merge pull request #649 from dveeden/newbackupprovider 3f18713 Merge pull request #671 from aldavud/fix-bug-in-578 b3c33f0 fix bug in GH-578 efa2f58 Merge pull request #673 from cmurphy/lint d6b1642 Fix lint warnings and ensure lint fails on warnings f5a693b (MODULES-1143) Add package_manage parameter 58508b7 Use backup providers dc71156 Check for full path for log-bin to stop puppet from managing directory “.” b64ca51 Merge pull request #669 from dveeden/lint-fix f2bfe9e Fix rake lint error in examples/server/config.php 7e81906 Merge pull request #668 from mhaskel/merge_3.2.x_to_master f93fbe3 Merge pull request #667 from mhaskel/tests_to_examples d665e8f move tests to examples a51b983 Merge pull request #664 from mhaskel/3.2.0-prep 8397805 Merge pull request #665 from mhaskel/lint_fixes 9f84ef7 3.2.0 prep 2635469 lint cleanup b9fbba3 Merge pull request #578 from franzs/new_root_options b6ab888 Merge pull request #661 from mhaskel/MODULES-1759 96f4d16 MODULES-1759: Remove dependency on stdlib >=4.1.0 b57191f Merge pull request #655 from rnelson0/remove_provider 14d5813 Merge pull request #660 from hunner/bump_stdlib 8a828aa Bugfix: increase minimum stdlib b3a38a8 Merge pull request #645 from dveeden/auth-plugins dc23fed Merge pull request #658 from hunner/fix_grant 506292a Make grant autorequire user 3fa7050 Merge pull request #646 from dveeden/emptypwd fa66b38 Merge pull request #657 from cmurphy/rspec 1394bd9 Pin rspec gems 9192a9d Merge pull request #656 from puppetlabs/revert-651-bug/master/root_account_fix 77b7dba Revert "(#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to depe..." a839489 Merge pull request #651 from lodgenbd/bug/master/root_account_fix e08aa01 (MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance. 279c13b Return an empty string for an empty input. b98c056 Merge pull request #652 from casharma/no_more_init 2a17e54 there is no class called mysql anymore (to test) c9c5eb3 (#MODULES-1058) root_password.pp cannot create /root/.my.cnf due to dependency 74e1969 Merge pull request #650 from cmurphy/fix_fix_tests 551d22f Fix acceptance tests from #648 d5defe2 Merge pull request #648 from cmurphy/fix_tests 80236d1 Fix acceptance tests from #641 8dbe7c0 Merge pull request #641 from dveeden/plugin 74132ec Add type & provider for managing plugins 367fcf0 Support authentication plugins 0623654 Merge pull request #644 from puppetlabs/revert-640-auth-plugins ccf37e7 Revert "Support for authentication plugins" 1a87bae Merge pull request #637 from dveeden/account_localhost 9a613bb Merge pull request #638 from dveeden/doc-secure bcb6150 Merge pull request #640 from dveeden/auth-plugins c04fed1 When fqdn==localhost account security breaks 305b0d2 Support authentication plugins d45b6a8 Make sure the example is somewhat secure 9f5539c Merge pull request #639 from juniorsysadmin/fix-service-lint-warning 2088fb8 Fix lint warning in server/service.pp 23c192d Merge pull request #634 from cyberious/ResourceTest 8d7ab1d Merge pull request #635 from mhaskel/MODULES-1520 d9d0271 MODULES-1520 add test to assert it does not break f92a24e MODULES-1520 - update username validation 4203867 Merge pull request #632 from mhaskel/future_parser_fix b20f043 Future parser fix in params.pp efeb01c Merge pull request #631 from cmurphy/master 83e87f5 Add IntelliJ files to the ignore list d3f7254 Merge pull request #616 from takumin/install_db_with_freebsd 5f62e6d Merge pull request #615 from KlavsKlavsen/master 457194c Merge pull request #629 from pishro-oss/master 263a9fa useless whitespace removed 9f9061e under Debian 8 package name for ruby mysql biding is called ruby-mysql, just like trusty. ea7d66a Merge pull request #628 from mhaskel/merge_3.1.x_into_master 09325e6 Merge pull request #627 from mhaskel/metadata_fix b12890d Forgot to add SLES12 to metadata. yay. bb12e9d Merge pull request #626 from mhaskel/3.1.0-prep c7f179d 3.1.0 prep 120e6b1 Merge pull request #625 from mhaskel/lint_cleanup a367b3e Clean up lint warnings 407e869 Merge pull request #624 from mhaskel/FM-2112 3c872ab Remove mysqltuner, fetch with staging instead 468986d Merge pull request #623 from mhaskel/FM-2111 a611686 Fix issues introduced in puppetlabs/puppetlabs-mysql#612 2f9820c Merge pull request #622 from mhaskel/puppet_not_shell 9361545 Use puppet() instead of shell() to install module dependencies aeb5ae5 Merge pull request #612 from lavoiesl/identifier-quoting 8e24162 Merge pull request #619 from cmurphy/master e8708f2 Add json gem 638b9c5 Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md 619fa7c Merge pull request #618 from cmurphy/sync 94448f3 Remove mime-types from .sync.yml 7d3962f mysql_install_db freebsd support a8fd4d3 ensure mysql-config-file and server package is in place before trying to start service - to ensure it gets started with correct settings and does not try to enable service before it actually exists :) 67bf7a3 Merge pull request #613 from justinstoller/maint/master/update-for-geppetto f0f5f64 Update for using Geppetto plugin in CI 60838a5 Reworked all identifier quoting detections f235f34 Merge pull request #611 from cmurphy/sles12 e23da83 Fix operating system release fact for SLES 137d0db Merge pull request #610 from cmurphy/sles12 25b6534 Add support for SLES 12 e0e797e Revert "Default to MariaDB for SLES 12" 510dfda Merge pull request #607 from laurenrother/summary 5a0ad6d Merge pull request #608 from cyberious/SLES12 8cc0083 Default to MariaDB for SLES 12 790305b Merge pull request #606 from michaeltchapman/usernameregex cfec01f Add metadata summary per FM-1523 fe0365e Support size 15 and 16 quoted usernames 31191b6 Merge pull request #604 from mhaskel/rebase_581 b7feb95 Merge pull request #605 from slamont/master 3b5d5af Proper containment for mysql::client in mysql::db 473a3c3 Fixed test classes 18265e0 Merge pull request #603 from mhaskel/mysql_test_fixes 11fb01c Fix test issues ab84a67 Merge pull request #574 from Mylezeem/allow_multiple_import_at_a_time 22b07ae Merge pull request #602 from theasci/fix-user-validation-regression 4f0d431 Fix regression in username validation 5e6a1c4 (MODULES-1338) Allow mysql::db to import several files 89762a7 Merge pull request #601 from mhaskel/merge_3.0.x 56e52fc Merge pull request #596 from NoodlesNZ/logbindir b06d3fe Merge remote-tracking branch 'upstream/3.0.x' into merge_3.0.x 08a66b7 Added log-bin dir creatation ad709af Merge pull request #591 from damonconway/MODULES-1484 810ceb1 Merge pull request #600 from hunner/release_3.0.0 46c53db clarify changelog for major release c5c1b38 Prepare for 3.0.0 release e5a300a Merge pull request #599 from mhaskel/metadata_fix 67bae9f Fix issues URL and make format match puppet module build 45b4f4b Merge pull request #598 from mhaskel/fix_for_beaker_with_1.8.7 0aee5c9 Prior to this there was generic :test group. 7de2316 [MODULES-1484] Add support for install_options for all package resources. 8dd37ae Merge pull request #594 from skroll/escape_backslash 1494412 Merge pull request #588 from maxenced/fix-mysql-user-allowed-char cdd7132 Improve checks for MySQL user's name. d9e5c95 Merge pull request #593 from vinzent/small_maint 9dbdd89 Fix escaped backslashes in grants 5d732bd (maint) add statement "MANAGED BY PUPPET" to my.cnf config file template and remove unused my.conf.cnf.erb template 02564bf Add new parameters create_root_user and create_root_my_cnf.

Reworked all identifier quoting detections

60838a5

Otherwise, trying to manage `debian-sys-maint` will fail miserably, quoted or not. Fixes #609

lavoiesl mentioned this pull request Nov 27, 2014

Allow dashes in username #609

Closed

lavoiesl reviewed Nov 27, 2014
View reviewed changes

igalic added a commit that referenced this pull request Dec 10, 2014

Merge pull request #612 from lavoiesl/identifier-quoting

aeb5ae5

Reworked all identifier quoting detections

igalic merged commit aeb5ae5 into puppetlabs:master Dec 10, 2014

lavoiesl deleted the identifier-quoting branch December 10, 2014 11:03

underscorgan pushed a commit to underscorgan/puppetlabs-mysql that referenced this pull request Dec 13, 2014

Fix issues introduced in puppetlabs#612

a611686

The regex updates caused failures in some places where it previously (correctly) worked.

hunner added a commit that referenced this pull request Dec 15, 2014

Merge pull request #623 from mhaskel/FM-2111

468986d

Fix issues introduced in #612

LukasAud added the bugfix label Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reworked all identifier quoting detections #612

Reworked all identifier quoting detections #612

lavoiesl commented Nov 27, 2014

lavoiesl Nov 27, 2014

Reworked all identifier quoting detections #612

Reworked all identifier quoting detections #612

Conversation

lavoiesl commented Nov 27, 2014

lavoiesl Nov 27, 2014

Choose a reason for hiding this comment